Add Yamux specific unit tests #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashatyrev
reviewed
Aug 15, 2023
| * @param data the data segment. | ||
| */ | ||
| class YamuxFrame(val id: MuxId, val type: Int, val flags: Int, val lenData: Long, val data: ByteBuf? = null) : | ||
| class YamuxFrame(val id: MuxId, val type: Int, val flag: Int, val length: Long, val data: ByteBuf? = null) : |
There was a problem hiding this comment.
I believe the field is still flags. Though I'm not sure there are use cases when more than one flag is set.
https://github.com/hashicorp/yamux/blob/master/spec.md#framing
There was a problem hiding this comment.
You are right. Fixed it.
Nashatyrev
reviewed
Aug 15, 2023
StefanBratanov
force-pushed
the
yamux_unit_tests
branch
from
75f77e0
to
49c9ac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #289