Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yamux] Clear caches when connection is closed #321

Merged
merged 3 commits into from
Sep 14, 2023
Merged

[Yamux] Clear caches when connection is closed #321

merged 3 commits into from
Sep 14, 2023

Conversation

StefanBratanov
Copy link
Collaborator

@StefanBratanov StefanBratanov commented Sep 13, 2023 •
edited
Loading

Clear sendBuffers and windowSizes when connection is closed (channelUnregistered Netty callback)

Nashatyrev
Nashatyrev approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov force-pushed the clear_caches_on_inactive branch from b28e6cc to 042ae54 Compare September 14, 2023 09:37
@StefanBratanov StefanBratanov merged commit 7d49700 into libp2p:develop Sep 14, 2023
@StefanBratanov StefanBratanov deleted the clear_caches_on_inactive branch September 14, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashatyrev Nashatyrev Nashatyrev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @Nashatyrev