Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test consistency #333

Merged

Conversation

StefanBratanov
Copy link
Collaborator

There is a tiny possibility the test reaches the test configured maxBufferedConnectionWrites (512) if the randomly selected indices are at the end (total bytes sent in this test are 1392), so made it so that 20 indices are selected from every 100 indices in which case the maxBufferedConnectionWrites will never be reached.

@StefanBratanov StefanBratanov merged commit 48a66ab into libp2p:develop Sep 28, 2023
2 checks passed
@StefanBratanov StefanBratanov deleted the fix_unit_test_consistency branch September 28, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant