Don't try and dial DNSADDR addresses #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should mainly be used for bootstrap with a DNS TXT record lookup to expand to list of nodes This removes a lot of log spam from failed dial attempts
|
Any thoughts on this @Nashatyrev ? |
Nashatyrev
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Looks good to me!
It feels like there should be more generic handling, but for now I'm fine with this additional 'if'
P.S. sorry for ignoring your PR, I seem to be subscribed for all repository notifications but for some reasons get only those where I mentioned explicitly. So feel free just to CC me on any new PRs
|
This PR is the follow up for #334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should mainly be used for bootstrap with a DNS TXT record lookup to expand to list of node multiaddrs
This removes a lot of log spam from failed dial attempts in kademlia