Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gossip: direct peers handling fix #398

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Gossip: direct peers handling fix #398

merged 3 commits into from
Nov 5, 2024
+164 −43

Conversation

tbenr
Copy link
Collaborator

@tbenr tbenr commented Nov 4, 2024 •
edited
Loading

fixes: #389

@tbenr
direct peers fix
ff0e88e 
and refactoring
@tbenr tbenr marked this pull request as draft November 4, 2024 13:10
Nashatyrev
Nashatyrev approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Yeah, tests are greatly appreciated :)

@tbenr
Copy link
Collaborator Author

tbenr commented Nov 4, 2024

Yeah, tests are greatly appreciated :)

on the way!

@tbenr tbenr marked this pull request as ready for review November 4, 2024 20:25
@tbenr
Copy link
Collaborator Author

tbenr commented Nov 4, 2024 •
edited
Loading

@Nashatyrev tests added

@tbenr tbenr merged commit 461d8c8 into libp2p:develop Nov 5, 2024
2 checks passed
@tbenr tbenr deleted the fix-direct-peers-handling branch November 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashatyrev Nashatyrev Nashatyrev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gossip: Revisit 'Direct' peer functionality
2 participants
@tbenr @Nashatyrev