Merge pull request #965 from Bnyro/master

fixes
libre-tube · Aug 4, 2022 · 02f0bb5 · 02f0bb5
2 parents eaf339b + c61df6b
commit 02f0bb5
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/app/release/output-metadata.json b/app/release/output-metadata.json
@@ -16,35 +16,35 @@
         }
       ],
       "attributes": [],
-      "versionCode": 15,
-      "versionName": "0.4.1",
+      "versionCode": 16,
+      "versionName": "0.4.2",
       "outputFile": "app-x86_64-release.apk"
     },
     {
       "type": "ONE_OF_MANY",
       "filters": [
         {
           "filterType": "ABI",
-          "value": "x86"
+          "value": "arm64-v8a"
         }
       ],
       "attributes": [],
-      "versionCode": 15,
-      "versionName": "0.4.1",
-      "outputFile": "app-x86-release.apk"
+      "versionCode": 16,
+      "versionName": "0.4.2",
+      "outputFile": "app-arm64-v8a-release.apk"
     },
     {
       "type": "ONE_OF_MANY",
       "filters": [
         {
           "filterType": "ABI",
-          "value": "arm64-v8a"
+          "value": "x86"
         }
       ],
       "attributes": [],
-      "versionCode": 15,
-      "versionName": "0.4.1",
-      "outputFile": "app-arm64-v8a-release.apk"
+      "versionCode": 16,
+      "versionName": "0.4.2",
+      "outputFile": "app-x86-release.apk"
     },
     {
       "type": "ONE_OF_MANY",
@@ -55,10 +55,10 @@
         }
       ],
       "attributes": [],
-      "versionCode": 15,
-      "versionName": "0.4.1",
+      "versionCode": 16,
+      "versionName": "0.4.2",
       "outputFile": "app-armeabi-v7a-release.apk"
     }
   ],
   "elementType": "File"
-}
+}
diff --git a/app/src/main/java/com/github/libretube/fragments/SearchResultFragment.kt b/app/src/main/java/com/github/libretube/fragments/SearchResultFragment.kt
@@ -22,7 +22,7 @@ class SearchResultFragment : Fragment() {
     private val TAG = "SearchResultFragment"
     private lateinit var binding: FragmentSearchResultBinding
 
-    private lateinit var nextPage: String
+    private var nextPage: String? = null
     private var query: String = ""
 
     private lateinit var searchAdapter: SearchAdapter
@@ -71,7 +71,7 @@ class SearchResultFragment : Fragment() {
         binding.searchRecycler.viewTreeObserver
             .addOnScrollChangedListener {
                 if (!binding.searchRecycler.canScrollVertically(1)) {
-                    fetchNextSearchItems()
+                    if (nextPage != null) fetchNextSearchItems()
                 }
             }
     }
@@ -99,7 +99,7 @@ class SearchResultFragment : Fragment() {
                     binding.noSearchResult.visibility = View.VISIBLE
                 }
             }
-            nextPage = response.nextpage!!
+            nextPage = response.nextpage
         }
     }
 
@@ -109,7 +109,7 @@ class SearchResultFragment : Fragment() {
                 RetrofitInstance.api.getSearchResultsNextPage(
                     query,
                     apiSearchFilter,
-                    nextPage
+                    nextPage!!
                 )
             } catch (e: IOException) {
                 println(e)

diff --git a/app/src/main/java/com/github/libretube/services/BackgroundMode.kt b/app/src/main/java/com/github/libretube/services/BackgroundMode.kt
@@ -292,7 +292,7 @@ class BackgroundMode : Service() {
         // kill old notification
         val notificationManager = getSystemService(Context.NOTIFICATION_SERVICE)
             as NotificationManager
-        notificationManager.cancel(1)
+        notificationManager.cancel(PLAYER_NOTIFICATION_ID)
     }
 
     override fun onBind(p0: Intent?): IBinder? {