Installation enhancements. #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2019 13:12
Added support for asking for environment variables if they do not exist. Resolved issue random password generation on MacOSX. Resolved issue with rake requiring bundle exec to overcome rake versioning issue. Added documentation for environment variables to README.md Added example.env to assist those who wish to prepopulate the environment variables required. modified: README.md new file: example.env modified: scripts/install
|
Thanks for your contribution, I'll merge it as it is now. It is a great improvement. Just for the context it is part of http://libre.sh and this install script is run by an automation, the provision script. It does provide the URL var also, it is all probably a lot less than ideal, but your commit will actually break it, do you think you could change your commit to make sure it is backward compatible? Thanks! |
|
G’day Pierre
Cool. I’ll change the script to check and use the old variables if
they exist.
Cheers
Keith John Hutchison
Software Development Director
Bringing Data to Life
<https://bringing-data-to-life.com.au/>0490 058 635
… On 8 Jan 2019, at 00:38, Pierre Ozoux ***@***.***> wrote:
Thanks for your contribution, I'll merge it as it is now.
It is a great improvement.
Just for the context it is part of http://libre.sh <http://libre.sh/> and this install script is run by an automation, the provision script.
It does provide the URL var also, it is all probably a lot less than ideal, but your commit will actually break it, do you think you could change your commit to make sure it is backward compatible?
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAtUCj8Y2-NvVotJ-Ldeqzt8wenHSXHzks5vA1TEgaJpZM4Zu856>.
|
|
Hey great work @csmu-cenr , I use it as is and it works like a charm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a few minor issues getting the install script to run on my device.
These are the changes I made to make the ./script/install file run on my Mac.
I also added
docker network create lb_webto README.md.I'm not yet sure why it's needed but the install script wouldn't run with it.
Cheers and thanks
Keith John Hutchison