-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assume unknown operating systems use ELF. #1120
Assume unknown operating systems use ELF. #1120
Conversation
There's a lot of new Unix-like operating systems out that that might port LibreSSL (my Sortix is among them) and they all use ELF. If the operating system doesn't use ELF or isn't an Unix, it doesn't have a chance at working out of this box anyway, and this change makes LibreSSL work on a generic and sufficiently featured POSIX system.
I'm open to adding a warning at the end of configure. In an earlier version, I did add a warning, but drowned out in the middle of the output, but it makes sense to put at at the end of configure. Personally if I port a package to a new platform, I very much want the breakage other people reported, so I can fix it. Artificial allowlists like this, on the other hand, makes porting to new platforms really difficult if one has to send patches to N projects that would otherwise just work out of the box. It's reasonable to expect people to contribute additional configuration if their platforms require unusual tweaks. |
I added a warning at the very end of configure, I think that'll work for everyone :) I'd prefer to not register Sortix as an supported operating system just yet, since your upstream sources don't work out of the box yet. I'm in the process of sending my local patches upstream so my patch is smaller :) |
Alright, thanks. Let's go with that. I'll merge with my next sync.
Happy to land any patches you send our way for sortix.
|
Thanks Theo for the quick review :) I sent some more patches to openbsd tech but think I'm stuck in the graylisting for now :) |
My patches got sent to openbsd-tech: https://marc.info/?l=openbsd-tech&m=173056673729921&w=2 |
Thanks. Got them in my inbox. Will take a look soon. |
There's a lot of new Unix-like operating systems out that that might port LibreSSL (my Sortix is among them) and they all use ELF. If the operating system doesn't use ELF or isn't an Unix, it doesn't have a chance at working out of this box anyway, and this change makes LibreSSL work on a generic and sufficiently featured POSIX system.