Replace uses of endbr64 with _CET_ENDBR from cet.h #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed checks here are due to github having a moment https://www.githubstatus.com/ |
busterb
commented
Feb 5, 2024
botovq
approved these changes
Feb 8, 2024
Avoid conflicts where alignment is specified later in the underlying assembly.
it is autogenerated, so don't keep it in tree
Using FC on Windows through a WSL mount assumes all filenames are UPPERCASE. So make the filenames UPPERCASE in the first place.
|
I assumed you left the endbr64 patch in here for ease of cherry-picking
to stable. It should however be committed to -current in CVS. Will you
take care of this or should I?
|
busterb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cet.h is needed for other platforms to emit the relevant .gnu.properties sections that are necessary for them to enable IBT. It also avoids issues with older toolchains on macOS that explode on encountering endbr64.
This also fixes an data alignment issue that occur when building on Windows where .section directives get a fixed 4 or 8 byte alignment, but then the section alignment is overridden on the next line, causing an assembler error.