-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support saving and loading directly into states 0 through 9 #13024
base: master
Are you sure you want to change the base?
Conversation
…s greater than or equal to the state number
…ot is greater than or equal to the state number
Hi, we appreciate the PR certainly. However, we have some runloop changes planned ahead and we might have to significantly rework it. In the process, when we get to it, we'd also like to reimplement this idea ourselves so that it wouldn't hurt performance in the process (all the extra conditionals added to the runloop here kinda concern us in its current state). So hopefully you'll understand that we want to freeze this PR until we get to this runloop state refactor. We thank your for your understanding. |
That's completely understandable; thanks for the update! Do you have more information on the runloop changes and the roadmap for it? |
@twinaphex Do you happen to have any updates on the roadmap for the runloop changes? |
-Fixed merge conflicts and updated code
@LibretroAdmin Hi, I've updated this PR with the latest on master after a long while. Can you have a look please? |
Guidelines
Description
This PR adds new hotkeys for directly saving and loading into save states. More details:
savestate_max_direct_slot
setting determines the highest slot that can be used with the hotkeys. For example, if this value is1
, hotkeys for directly saving and loading slots 0 and 1 can be used. This defaults to -1, which disables the feature.savestate_max_direct_slot
.Related Issues
#12990
Reviewers
@jdgleaver @twinaphex @bozothegeek