Allow using system spirv cross #17080
Open
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: libretro#17079 * Makefile.common [HAVE_BUILTINSPIRV_CROSS]: Include bundled SPIRV-Cross sources only when using the builtin option, else... [!HAVE_BUILTINSPIRV_CROSS]: Extend CXXFLAGS and LIBS. * qb/config.libs.sh (BUILTINSPIRV_CROSS): Register new check_enabled configure option, and add libraries/header checks. * qb/config.params.sh (HAVE_BUILTINSPIRV_CROSS): Register new parameter.
…bles. C_INCLUDE_PATH and CPLUS_INCLUDE_PATH are consulted by GCC, so should be considered by check_libs as well. * qb/config.libs.sh (INCLUDES): Add C_INCLUDE_PATH and CPLUS_INCLUDE_PATH values to it.
|
This is an issue as can be seen in the CI jobs. We don't really want our current platforms to use system-provided SPIRV-Cross. You can add this functionality but it should be optional and should not be the default. |
It already should be optional; unless someone passes the |
|
I've looked at the WiiU build failure, and I'm puzzled. Is it possible to build with V=1 in to see which CXXFLAGS were used? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change teaches the build system to use a system provided SPIRV-Cross library when RetroArch is configured via
configure --disable-builtinspirv_crossflag.Related Issues
#17079