Add OriginalAspect and OriginalAspectRot uniforms #17123
Merged
+329
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by defining _RARCH_HAS_COREASPECT_UNIFORM early in the shader source, just after "#extension GL_GOOGLE_cpp_style_line_directive : require"
It reports CoreAspect value or 1/CoreAspect when the content is rotated by 90 or 270 deg.
…pport (was _RARCH_HAS_COREASPECT_UNIFORMS)
…lAspect, OriginlAspectRot, _HAS_ORIGINALASPECT_UNIFORMS
...how on earth did it worked for UBO !?
|
This seems to be working as intended, and I verified that it works with d3d drivers, as well. @HyperspaceMadness @LibretroAdmin Would either of you care to take a look? |
|
Sure. @HyperspaceMadness Giving you a 5 day window to let us know if you think this is good to have. |
|
This looks really great @kokoko3k , my only comment would be that it might be good to have OriginalAspectRot to be renamed OriginalAspectRotated. At first glance, my first guess was that OriginalAspectRot was a uniform which told me what the rotation was versus the rotated aspect Great work on this! |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 2 uniforms: OriginalAspect and OriginalAspectRot.
They are intended to be used by shaders when Retroarch aspect is set to something different than Core Provided.
In such scenarios, shaders have no access to what is the correct apect.
OriginalAspect reports the aspect reported by the core, while OriginalAspectRot reports 1/OriginalAspect then the content is rotated by 90° or 270°