Add Frametime Uniforms #17155
Merged
Add Frametime Uniforms #17155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by defining _RARCH_HAS_COREASPECT_UNIFORM early in the shader source, just after "#extension GL_GOOGLE_cpp_style_line_directive : require"
It reports CoreAspect value or 1/CoreAspect when the content is rotated by 90 or 270 deg.
…pport (was _RARCH_HAS_COREASPECT_UNIFORMS)
…lAspect, OriginlAspectRot, _HAS_ORIGINALASPECT_UNIFORMS
...how on earth did it worked for UBO !?
_HAS_ORIGINALASPECT_UNIFORMS is (#)defined and can be used to query for them.
|
@HyperspaceMadness Let me know what you think |
|
@HyperspaceMadness Any commentary on this yet? |
|
Looks good! One note that in the changed files the internal variables are named core_fps while the uniform is Original_FPS, it might be good to keep these consistent for code searches Great work! |
Just done. |
|
Looks like it's good to go @LibretroAdmin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add 2 new Uniforms:
CoreFPS: the FPS reported by the core
FrameTimeDelta: The time passed between thte current and previous frame.
The define _HAS_FRAMETIME_UNIFORMS can be used by the shader to query for them
Support for glsl and Slang (tested and working on: GLCore, Vulkan, Metal, d3d10,11,12)
Reviewers
@hizzlekizzle
@HyperspaceMadness