Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoconf profile saving for devices not in their default port. #17156

Merged

Conversation

zoltanvb
Copy link
Contributor

@zoltanvb zoltanvb commented Nov 3, 2024

Description

User slot (player #) and joypad driver port is by default the same, but it can be changed either manually or automatically (reserved device). Use the correct index for detecting values associated with the port.

Fault can be reproduced by manually changing the device to be associated with player 2, and then saving autoconf.

Related Issues

Fixes #3578 , thank you for reporting (even if the wait was rather long!)

User slot (player #) and joypad driver port is by default the same, but
it can be changed either manually or automatically (reserved device).
Use the correct index for detecting values associated with the port.
@LibretroAdmin LibretroAdmin merged commit 3d221f2 into libretro:master Nov 3, 2024
27 checks passed
@zoltanvb zoltanvb deleted the save_autoconf_for_second_device branch November 18, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save Autoconfig overwrites device #0 instead of currently selected device
2 participants