Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable netlink on windows #265

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

samrussell
Copy link

Fixes #201

Add WSAStartup call and wrap ioctl and close calls with their win32 equivalents. Minimal logging to check for initial socket() failure.

Tested on win10 x64 and win11 x64 with retroarch

@LibretroAdmin
Copy link
Contributor

Hi, ideally we make this work for the Mingw build too instead of just MSVC.

@samrussell
Copy link
Author

Does my change break anything in the mingw build or does it just not improve it?

If it doesn't make anything worse and it does make some things better then would you be happy to accept the PR?

@LibretroAdmin
Copy link
Contributor

Is it not possible for you to see if you can get this to compile for the regular Windows build too?

Also, if I may ask, what is the current state of this on Linux? So from what I understand for Linux netplay is already enabled and it's just not enabled for the Windows builds yet?

@samrussell
Copy link
Author

Also, if I may ask, what is the current state of this on Linux?

How exactly would I know this?

Is it not possible for you to see if you can get this to compile for the regular Windows build too?

It's entirely possible, I'm just not going to do it. I found a bug for my platform, wrote and tested a fix, and I'm offering it to you as a courtesy. If you want to merge it then you can. If you don't want to merge it then don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket Error for Game Boy Link Server
2 participants