Add HuC3 mapper support #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports 'rudimentary' HuC3 mapper support from https://github.com/Dabomstew/gambatte-speedrun (internal speaker and P2P IR is omitted, but I think it should be fine for playing games). All credit goes to the original author.
This should allow the core to run the following:
Robopon - Sun Version (USA)
Robot Ponkottsu: Sun, Star, Moon and Comic Bom Bom Special Version (Japan)
Pocket Family / Pocket Family GB2 (Japan)
I don't speak Japanese, so I was only able to test Robopon - Sun Version. Saving works, the real time clock works (and is properly synchronised - should avoid the infamous 'no random encounters' bug), and save states work. I didn't get very far into the game (it's a 35 hour RPG...), but I encountered no issues (and there are no reported issues on the gambatte-speedrun repo, so I assume it's all good).
Annoyingly, this again invalidates existing save state files (the HuC3 needs some extra data), but I guess that's a necessary evil...
(Oh, and this should close issue #83)