Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #258

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Improve logging #258

merged 4 commits into from
Dec 15, 2023

Conversation

lenguyenthanh
Copy link
Member

@lenguyenthanh lenguyenthanh commented Dec 12, 2023 •
edited
Loading

  • Log all failed requests (which are not 2xx and not 404)
  • Add moves when logging work

@lenguyenthanh lenguyenthanh marked this pull request as draft December 12, 2023 21:30
@lenguyenthanh lenguyenthanh changed the title Alway log failed requests Always log failed requests Dec 12, 2023
@lenguyenthanh lenguyenthanh changed the title Always log failed requests Improve logging Dec 12, 2023
@lenguyenthanh lenguyenthanh marked this pull request as ready for review December 15, 2023 09:17
@lenguyenthanh lenguyenthanh merged commit 9abdc73 into master Dec 15, 2023
2 checks passed
@lenguyenthanh lenguyenthanh deleted the api-logging branch December 15, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lenguyenthanh