-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize Divider.mixedness #441
Conversation
3a2ecc6
to
ee5d46e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice, thanks Niklas. I was thinking to do the same but too scared. Just added small suggestion, otherwise LGTM.
Switching from
|
I didn't expect that big of improvement either. It makes me wondering how much we can gain if we don't use |
I guess the performance penalty is mostly caused by but maybe the |
Before:
After, first attempt:
Additionally, precomputing mixedness regions again:
Additionally, using
mapReduce
:Additionally, using
Long
instead ofBitboard
region masks: