Support impossible checks when validate position #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenguyenthanh
requested changes
Jul 14, 2023
Move implementation to standard. Fix unsafe calls to get, head and tail.
|
I fixed the comments, moved the implementation to the standard variant, this made the file changes more but hopefully it's clearer. Also, checking for optional in multiple places made the look more complex than it actually is, please let me know if you have any more suggestion to improve them. |
lenguyenthanh
force-pushed
the
Support_impossible_checks_when_validate_position
branch
from
868fcc8
to
f1710ab
Compare
|
Thanks @Oziomajnr, I took the liberty to do some refactor to make the logic more clear. Please check if you think it's good. I think we can improve it's a bit further, but I think it's good for now. |
lenguyenthanh
approved these changes
Jul 16, 2023
|
Thanks, the changes looks good, thanks. |
|
Hey @Oziomajnr, FYI, this is a breaking change, so we're discussion the best way to integrated it with lila. So this is on hold atm. |
…sition * master: Specialize ByRole for bitboard.Board Specialize ByColor for bitboard.Board
ornicar
added a commit
to lichess-org/lila
that referenced
this pull request
Jul 18, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited the fix to standard variant for now, as I need to test for other variants too.
Fixes #403