11.3.1 #66
Merged
11.3.1 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove extra definitions recently added to OpaqueX - Rename OpaqueInt -> RelaxedOpaqueInt - Rename OpaqueIntSafer -> RichOpaqueInt - Rename FunctionWrapper.apply -> exec The apply method is overloaded with TotalWrapper.apply, leading to spurious build errors. And also it seems like best practice to explicitly unwrap an Opaque function if we want to use it. - Restore trait to SameRuntime (requiring by FunctionalInterface tag) Note: Currently only use of RichOpaqueInt is Centis. Many users of OpaqueInt in lila need to be renamed to RelaxedOpaqueInt, and many users of FunctionWrapper need the 'exec' method call added. There are related PRs in scalachess, lila-ws, and lila for the upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Currently only use of RichOpaqueInt is Centis. Many users of OpaqueInt in lila need to be renamed to RelaxedOpaqueInt, and many users of FunctionWrapper need the 'exec' method call added.
There are related PRs in scalachess, lila-ws, and lila for the upgrade.