Merge pull request #1538 from georgel-pop-lr/LPS-156925

fix: Reset uibridge definitions each time we destroy and create and editor (#1537)
liferay · Aug 31, 2022 · 23d8609 · 23d8609
2 parents bf8642f + 6fd47b2
commit 23d8609
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/src/components/uibridge/button.jsx b/src/components/uibridge/button.jsx
@@ -146,6 +146,8 @@ if (!CKEDITOR.plugins.get('ae_buttonbridge')) {
 		 * @param {Object} editor The CKEditor instance being initialized
 		 */
 		beforeInit(editor) {
+			BUTTON_DEFS[editor.name] = {};
+
 			editor.ui.addButton = function(buttonName, buttonDefinition) {
 				this.add(buttonName, CKEDITOR.UI_BUTTON, buttonDefinition);
 			};

diff --git a/src/components/uibridge/menu-button.jsx b/src/components/uibridge/menu-button.jsx
@@ -194,6 +194,8 @@ if (!CKEDITOR.plugins.get('ae_menubuttonbridge')) {
 		 * @param {Object} editor The CKEditor instance being initialized
 		 */
 		beforeInit(editor) {
+			MENUBUTTON_DEFS[editor.name] = {};
+
 			editor.ui.addMenuButton = function(
 				menuButtonName,
 				menuButtonDefinition

diff --git a/src/components/uibridge/panel-menu-button.jsx b/src/components/uibridge/panel-menu-button.jsx
@@ -197,6 +197,8 @@ if (!CKEDITOR.plugins.get('ae_panelmenubuttonbridge')) {
 		 * @param {Object} editor The CKEditor instance being initialized
 		 */
 		beforeInit(editor) {
+			PANEL_MENU_DEFS[editor.name] = {};
+
 			editor.ui.addPanelMenuButton = function(
 				panelMenuButtonName,
 				panelMenuButtonDefinition

diff --git a/src/components/uibridge/richcombo.jsx b/src/components/uibridge/richcombo.jsx
@@ -235,6 +235,8 @@ if (!CKEDITOR.plugins.get('ae_richcombobridge')) {
 		 * @param {Object} editor The CKEditor instance being initialized
 		 */
 		beforeInit(editor) {
+			RICH_COMBO_DEFS[editor.name] = {};
+
 			editor.ui.addRichCombo = function(
 				richComboName,
 				richComboDefinition