fix: handle module aliases that start with "." correctly #1196

izaera · 2024-03-04T14:47:10Z

See https://liferay.atlassian.net/browse/LPD-19292

See https://liferay.atlassian.net/browse/LPD-19292 and https://github.com/defunctzombie/package-browser-field-spec?tab=readme-ov-file#alternate-main---basic for more info.

bryceosterhaus

LGTM!

izaera added 3 commits March 4, 2024 14:12

fix: make local aliases work

f260a6f

See https://liferay.atlassian.net/browse/LPD-19292 and https://github.com/defunctzombie/package-browser-field-spec?tab=readme-ov-file#alternate-main---basic for more info.

fix: don't replace files when they are aliased to themselves

3ccbf52

test: add tests for aliases parsing

cd7def2

github-actions bot added js-toolkit 2.x labels Mar 4, 2024

izaera requested a review from bryceosterhaus March 4, 2024 14:47

bryceosterhaus reviewed Mar 5, 2024

View reviewed changes

izaera merged commit 05ec5e2 into liferay:master Mar 5, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: handle module aliases that start with "." correctly #1196

fix: handle module aliases that start with "." correctly #1196

izaera commented Mar 4, 2024

bryceosterhaus left a comment

fix: handle module aliases that start with "." correctly #1196

fix: handle module aliases that start with "." correctly #1196

Conversation

izaera commented Mar 4, 2024

bryceosterhaus left a comment

Choose a reason for hiding this comment