fix: handle module aliases that start with "." correctly

maintenance/projects/js-toolkit/packages/liferay-npm-build-tools-common/src/__tests__/__fixtures__/alias/alias-without-dot.json

@@ -0,0 +1,5 @@
+{
+	"browser": {
+		"./index": "index-shim.js"
+	}
+}

maintenance/projects/js-toolkit/packages/liferay-npm-build-tools-common/src/__tests__/__fixtures__/alias/main-without-dot.json

@@ -0,0 +1,4 @@
+{
+	"main": "index",
+	"browser": "index-shim.js"
+}

maintenance/projects/js-toolkit/packages/liferay-npm-build-tools-common/src/__tests__/alias.test.ts

@@ -107,4 +107,21 @@ describe('loadAliases', () => {
 
 		expect(aliases['toString']).toBeUndefined();
 	});
+
+	it('works when the main field does not start with .', () => {
+		const aliases = loadAliases(fixturesDir.join('main-without-dot.json'), [
+			'browser',
+		]);
+
+		expect(aliases['./index']).toEqual('./index-shim.js');
+	});
+
+	it('works when value does not start with .', () => {
+		const aliases = loadAliases(
+			fixturesDir.join('alias-without-dot.json'),
+			['browser']
+		);
+
+		expect(aliases['./index']).toEqual('./index-shim.js');
+	});
 });

maintenance/projects/js-toolkit/packages/liferay-npm-build-tools-common/src/alias.ts

@@ -117,7 +117,11 @@ export function loadAliases(
 				}
 
 				if (aliasConfig === false || typeof aliasConfig === 'string') {
-					const main = pkgJson['main'] || './index.js';
+					let main = pkgJson['main'] || './index.js';
+
+					if (!main.startsWith('.')) {
+						main = `./${main}`;
+					}
 
 					aliases[main] = aliasConfig;
 				}
@@ -140,6 +144,18 @@ export function loadAliases(
 				delete aliases[key];
 			}
 		});
+
+		// Normalize local aliases to make them start with `./`
+
+		Object.keys(aliases).forEach((key) => {
+			if (key.startsWith('.')) {
+				const value = aliases[key];
+
+				if (typeof value === 'string' && !value.startsWith('.')) {
+					aliases[key] = `./${value}`;
+				}
+			}
+		});
 	}
 
 	// Store in cache

maintenance/projects/js-toolkit/packages/liferay-npm-bundler-plugin-replace-browser-modules/src/index.ts

@@ -107,22 +107,26 @@ function processAliases(
 					const absToFile = alias.absDir.join(
 						new FilePath(alias.to as string, {posix: true})
 					);
-					const fromRelToFile = absFromFile
-						.dirname()
-						.relative(absToFile);
 
-					rewriteFile(
-						absFromFile,
-						`/* redirected by alias field(s) in ${rootRelAbsDirPosixPath} */`,
-						`module.exports = require('./${fromRelToFile.asPosix}');`
-					);
+					if (!absToFile.is(absFromFile)) {
+						const fromRelToFile = absFromFile
+							.dirname()
+							.relative(absToFile);
+
+						rewriteFile(
+							absFromFile,
+							`/* redirected by alias field(s) in ${rootRelAbsDirPosixPath} */`,
+							`module.exports = require('./${fromRelToFile.asPosix}');`
+						);
+
+						log.info(
+							'replace-browser-modules',
+							`Redirected file '${rootRelFilePosixPath}' to ` +
+								`'./${fromRelToFile.asPosix}' as configured in ` +
+								`'${rootRelAbsDirPosixPath}'`
+						).linkToCode(2);
+					}
 
-					log.info(
-						'replace-browser-modules',
-						`Redirected file '${rootRelFilePosixPath}' to ` +
-							`'./${fromRelToFile.asPosix}' as configured in ` +
-							`'${rootRelAbsDirPosixPath}'`
-					).linkToCode(2);
 					break;
 				}