Skip to content

Commit

Permalink
Merge pull request #820 from SethTisue/release-1.1.4
Browse files Browse the repository at this point in the history
Update sbt-mima-plugin to 1.1.4
  • Loading branch information
SethTisue authored Aug 9, 2024
2 parents f9ae9ec + 701bfcd commit dd8804b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 25 deletions.
9 changes: 5 additions & 4 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,26 +17,27 @@ See the [prerequisites](#prerequisites) if this is your first release.
* [ ] In sbt run `clean`, particularly if you've recently bumped `scalaVersion`.
* [ ] In sbt run `publishSigned`. You should start seeing "published mima-.. to https://oss.sonatype.org/service/local/staging/deploy/maven2/..".
* [ ] In sbt run `++2.13` `coreJVM/publishSigned` `coreNative/publishSigned`
* [ ] In sbt run `++3.2` `coreJVM/publishSigned` `coreNative/publishSigned`
* [ ] In sbt run `++3.3` `coreJVM/publishSigned` `coreNative/publishSigned`
* [ ] [Find and close][sonatype/staging-repos] your staging repository. (See Sonatype's [Releasing the Deployment][sonatype/guide] guide.)
* [ ] Switch to a branch (e.g. `git checkout -b release-1.x.y`)
* [ ] In `project/plugins.sbt` update `sbt-mima-plugin`.
* [ ] In `project/MimaSettings.scala` update `mimaPreviousVersion` & clear out `mimaBinaryIssueFilters`.
* [ ] In sbt run `testStaging` **WITHOUT** `reload`ing first (`testStaging` adds the staging resolvers & runs `reload`).
* [ ] Run `git commit -am 'Update sbt-mima-plugin to 1.x.y'` and PR it (`gh pr create` or `hub pull-request`). The PR won't pass CI until the release is available on Maven Central. You may poll [repo1 directly][repo1/list] (note the trailing slash in the URL).
* [ ] Update the version numbers in `RELEASING.md`
* [ ] Run `git add -p` and `git commit -am 'Update sbt-mima-plugin to 1.x.y'` and PR it (`gh pr create` or `hub pull-request`). The PR won't pass CI until the release is available on Maven Central. You may poll [repo1 directly][repo1/list] (note the trailing slash in the URL).
* [ ] [Find and release][sonatype/staging-repos] your staging repository.
* [ ] Switch back to the main branch and run `git push --follow-tags` to push the tag.
* [ ] [Find and merge][prs/list] your update PR.
* [ ] [Find and hit "Publish Release"][releases/list] on the draft GitHub release.

[compare/view]: https://github.com/lightbend-labs/mima/compare/1.1.2...main
[compare/view]: https://github.com/lightbend-labs/mima/compare/1.1.4...main
[issues/new]: https://github.com/lightbend-labs/mima/issues/new
[prs/list]: https://github.com/lightbend-labs/mima/pulls
[releases/list]: https://github.com/lightbend-labs/mima/releases
[releases/new]: https://github.com/lightbend-labs/mima/releases/new

[RELEASING.md]: https://raw.githubusercontent.com/lightbend-labs/mima/main/RELEASING.md
[repo1/list]: https://repo1.maven.org/maven2/com/typesafe/mima-core_2.12/1.1.2/
[repo1/list]: https://repo1.maven.org/maven2/com/typesafe/mima-core_2.12/1.1.4/
[sonatype/guide]: https://central.sonatype.org/pages/releasing-the-deployment.html
[sonatype/staging-repos]: https://oss.sonatype.org/#stagingRepositories
[ci]: https://github.com/lightbend-labs/mima/actions/workflows/ci.yml
Expand Down
21 changes: 1 addition & 20 deletions project/MimaSettings.scala
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import com.typesafe.tools.mima.plugin.MimaPlugin.autoImport._

object MimaSettings {
// clear out mimaBinaryIssueFilters when changing this
val mimaPreviousVersion = "1.1.3"
val mimaPreviousVersion = "1.1.4"

val mimaSettings = Def.settings (
mimaPreviousArtifacts := Set(pluginProjectID.value.withRevision(mimaPreviousVersion)
Expand All @@ -24,25 +24,6 @@ object MimaSettings {
// * com.typesafe.tools.mima.core.ProblemFilters
// * com.typesafe.tools.mima.core.*Problem
// * com.typesafe.tools.mima.core.util.log.Logging

ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#DefDef.copy"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("com.typesafe.tools.mima.core.TastyUnpickler#DefDef.copy$default$3"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#DefDef.this"),
ProblemFilters.exclude[MissingTypesProblem]("com.typesafe.tools.mima.core.TastyUnpickler$DefDef$"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#DefDef.<init>$default$3"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#DefDef.apply"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#DefDef.apply$default$3"),
ProblemFilters.exclude[IncompatibleSignatureProblem]("com.typesafe.tools.mima.core.TastyUnpickler#DefDef.unapply"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler.copyPrivateWithin"),
ProblemFilters.exclude[ReversedMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#TermMemberDef.classPrivate"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#ValDef.copy"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("com.typesafe.tools.mima.core.TastyUnpickler#ValDef.copy$default$3"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#ValDef.this"),
ProblemFilters.exclude[MissingTypesProblem]("com.typesafe.tools.mima.core.TastyUnpickler$ValDef$"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#ValDef.<init>$default$3"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#ValDef.apply"),
ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.core.TastyUnpickler#ValDef.apply$default$3"),
ProblemFilters.exclude[IncompatibleSignatureProblem]("com.typesafe.tools.mima.core.TastyUnpickler#ValDef.unapply")
),
)
}
2 changes: 1 addition & 1 deletion project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resolvers ++= (if (isStaging) List(stagingResolver) else Nil)

addSbtPlugin("com.github.sbt" % "sbt-dynver" % "5.0.1")
addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.2.1")
addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.3")
addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.4")

addSbtPlugin("org.portable-scala" % "sbt-scala-native-crossproject" % "1.3.2")
addSbtPlugin("org.scala-native" % "sbt-scala-native" % "0.5.4")

0 comments on commit dd8804b

Please sign in to comment.