-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the same base classpath for empty packages as is used for normal packages #769
Conversation
Hi @bpholt, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
FYI, I signed the updated CLA |
@SethTisue friendly ping to see if you can approve this workflow for CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes more sense.
I think we could close #768 at least, once this is released. |
as for releasing, I've opened #774 and self-assigned |
Works for me! Thank you! |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.typesafe:sbt-mima-plugin](https://togithub.com/lightbend/mima) | plugin | patch | `1.1.2` -> `1.1.3` | --- ### Release Notes <details> <summary>lightbend/mima (com.typesafe:sbt-mima-plugin)</summary> ### [`v1.1.3`](https://togithub.com/lightbend/mima/releases/tag/1.1.3) [Compare Source](https://togithub.com/lightbend/mima/compare/1.1.2...1.1.3) #### Notable changes - use the same base classpath for empty packages as is used for normal packages by [@​bpholt](https://togithub.com/bpholt) in [lightbend-labs/mima#769 #### Other changes - build tweaks by [@​SethTisue](https://togithub.com/SethTisue) in [lightbend-labs/mima#752 - update releasing steps by [@​SethTisue](https://togithub.com/SethTisue) in [lightbend-labs/mima#751 - Update coursier to 2.1.2 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#756 - Update coursier to 2.1.3 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#757 - Update coursier to 2.1.4 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#759 - Update coursier to 2.1.5 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#767 - Update munit to 1.0.0-M8 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#766 - Update nscplugin, sbt-scala-native, ... to 0.4.14 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#763 - Update sbt to 1.8.3 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#760 - Update sbt to 1.9.0 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#762 - Update sbt to 1.9.1 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#770 - Update sbt to 1.9.2 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#773 - Update sbt-dynver to 5.0.1 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#758 - Update sbt-mima-plugin to 1.1.2 by [@​SethTisue](https://togithub.com/SethTisue) in [lightbend-labs/mima#750 - Update sbt-scala-native-crossproject to 1.3.0 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#753 - Update sbt-scala-native-crossproject to 1.3.1 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#755 - Update sbt-scala-native-crossproject to 1.3.2 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#772 - Update scala-library, scala-reflect to 2.12.18 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#764 - Update scala-library, scala-reflect to 2.13.11 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#765 - Update scala3-library to 3.3.0 by [@​scala-steward](https://togithub.com/scala-steward) in [lightbend-labs/mima#761 #### New Contributors - [@​bpholt](https://togithub.com/bpholt) made their first contribution in [lightbend-labs/mima#769 **Full Changelog**: lightbend-labs/mima@1.1.2...1.1.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/slick/slick). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
References #768, #702, #743
Like @rossabaker in #743, I also don't know much about MiMa's internals, but from what I've poked around at, this seems to make sense?