Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning Specification Meeting 2022/09/26 #1028

Closed
15 of 27 tasks
t-bast opened this issue Sep 22, 2022 · 2 comments
Closed
15 of 27 tasks

Lightning Specification Meeting 2022/09/26 #1028

t-bast opened this issue Sep 22, 2022 · 2 comments

Comments

@t-bast
Copy link
Collaborator

t-bast commented Sep 22, 2022

The meeting will take place on Monday 2022/09/26 at 8pm UTC (5:30am Adelaide time) on Libera Chat IRC #lightning-dev. It is open to the public.

A video link is available for higher bandwidth communication: https://meet.jit.si/Lightning-Spec-Meeting

Pull Request Review

Waiting for interop

Long Term Updates

Backlog

The following are topics that we should discuss at some point, so if we have time to discuss them great, otherwise they slip to the next meeting.

@t-bast t-bast pinned this issue Sep 22, 2022
@Roasbeef
Copy link
Collaborator

Roasbeef commented Sep 26, 2022

mandatory tlv onion:

  • now about 0.01% using the old format, seems safe to remove the old ones
  • new commit to be added to the PR to update the test vectors (remove old, add new specific ones)
  • side question of: what's the new actual hop limit?
    • payment secret makes it shorter, and also payment metadata
    • seems to be > 20, but actual limit need to be pinned down, could be future test vector update

#1026 dynamic commitments:

  • simpler take, inspired by quiescence/stfu proposal
  • doesn't allow to take place w/ HTLCs active
  • concerns that something like that would be too limiting:
    • rationale was that recent insights led to the belief that for spicing type protocols, you can't have any HTLCs in the zero htlc anchors land
    • however this is just about the commitment and not the funding output, so no HTLCs active
  • related is that you want to be able to properly "reject" certain fields
    • related to ideas to add "suggestions" to the warning message
    • can be used to tell ppl the dust limit is too high or low (or w/e)
    • modification from the current draft, that wants the reply to have bits w.r.t what isn't included
  • greater question of splicing as a specific case of dynamic commitments:
    • can kind of separate them into things that change the funding outpoint vs not
    • then in the future splicing can be folded into something like this?
  • flow control for HTLCs
    • could be an initial thing to use to start being dynamic
    • no reason for the other party to be able use all 483 at once, flow control, AIMD

zero htlc fee test vectors:

  • need one other ACK, then probably ready to go

reviving old convo on pruning behavior:

  • eclair went to fix their pruning behavior, realized that if your peer isn't properly pruning they'll send you partial channel updates:
    • you'll revive something, but then will sort of flap and remove all over again
  • desire to converge on lnd's pruning behavior:
    • remove if either side is a zombie
    • only revive if the side that pruned is the one that's the one advertising the channel update again

max dust limit value:

  • related to dyn commitments stuff
  • call for reviewers on this
  • related to tx v3 stuff, would allow us to update channels to opt into the new relay policies in the future (w/e they are)

removing the onion TLV message size:

  • moving to 256 to 1024 could be a harder change (even though it was a SHOULD), since most implementations have effectively hard coded this value
  • so perhaps we just need to upgrade to allow senders to handle, and we can not have to add signalling?
  • in theory impls like CL, already support larger values, but needs to be tested out in practice
  • action item: figure out how nodes handle them in practice

route blinding:

  • CL has the payment aspect working now, has a dummy blinded route at the end (1 hop to me)
    • minimal implementation just replacing the payment secret w/ this
  • next step: to implement when you really need one, has a private channel, etc
  • for testing, can just provide a custom RPC w/ a bolt12 invoice w/o an offer just to be able to test
    • may not be exposed permanently, but can test all the logic, etc works properly

onion messages:

  • few changes to the naming scheme, now mainly wanting to do cross impl testing

impact of changing funding_locked to channel_ready:

  • had rippling implications for CL, also in offers they sign the name at times
  • lnd never renamed

turn based co-op close:

  • wants the warning message to be able to say if the fee is too high or w/e
  • alternatively, could just do it s.t you never send sigs until the very end
    • other q's is: does both sides send the sig at the very end?
    • maybe just send it again, or be comfortable with not being able to broadcast
  • dual funding+splicing off shoot:
    • splice close proposal, basically being able to close out in a special way (eg: close out into diff channels or w/e)
    • would also have multiple versions, in case the other one never actually fully confirms
  • what should actually be the change to closing process?
    • few diff paths on the table: turn based, only send sigs at the end, mega arbitrary closing

interop:

  • Bolt7: add channel update flag for scid alias #999 now ready for CL and elcair
  • dual funding and channel reserve:
    • for phoenix, the non-initiator gets zero reserve
    • maybe can be done after the fact
  • force close on error not chan reest:
    • lnd needs to check this doesn't break the SCB flow
    • CL has a version of this now themselves

@t-bast
Copy link
Collaborator Author

t-bast commented Sep 27, 2022

I tested interop between eclair and cln today for #999, we're all good!

@t-bast t-bast unpinned this issue Oct 6, 2022
@t-bast t-bast closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants