Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onion message test vectors #2458

Conversation

valentinewallace
Copy link
Contributor

Partially addresses #1607. Should unblock the OM spec merge 🤞

Also re-alphabetize the imports in the onion message functional tests.

Co-authored-by: Carla Kirk-Cohen <kirkcohenc@gmail.com>
@jkczyz jkczyz self-requested a review July 27, 2023 22:21
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother to check if the vectors match the BOLTs, but test looks fine.

Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified they match the BOLT test vectors with the caveat of excluding the prepended 0x0201 (513) OM message type.

@valentinewallace valentinewallace merged commit 4a4163f into lightningdevkit:main Aug 14, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants