Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to rustc 1.63.0 #2681

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Bump MSRV to rustc 1.63.0 #2681

merged 3 commits into from
Dec 11, 2023

Commits on Dec 8, 2023

  1. Bump MSRV to rustc 1.63.0 and edition to 2021 

    .. which is a reasonable common ground, also supported by Debian stable.
    @tnull
    tnull committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ddf2509 View commit details
    Browse the repository at this point in the history

  2. Move lightning-custom-message to main workspace 

    Since we now have a consistent MSRV and edition, we can move
`lightning-custom-message` to the main
workspace.
    @tnull
    tnull committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7301ff0 View commit details
    Browse the repository at this point in the history

  3. Manually download bitcoind/electrs for CI tests 

    Previously, we used the auto-download feature of the
`electrsd`/`bitcoind` crates. While convenient, they unnecessarily
introduced a lot of dependecies (`zip`, `zstd`, `time`, etc.) to our
test environment which needed pinning for the MSRV of 1.63.

Here, we introduce a new `no_download` config flag to the
`lightning-transaction-sync` crate allowing us to disable this
auto-download feature in CI, where we now opt to download the
corresponding binaries manually. We keep the default-auto-download as a
convenience feature for running tests locally though.
    @tnull
    tnull committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f368fac View commit details
    Browse the repository at this point in the history