Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running into panic when choose 0 sats to go to myself in zombie channel recovery #158

Closed
Liongrass opened this issue Aug 26, 2024 · 5 comments · Fixed by #159
Closed

Running into panic when choose 0 sats to go to myself in zombie channel recovery #158

Liongrass opened this issue Aug 26, 2024 · 5 comments · Fixed by #159

Comments

@Liongrass
Copy link

I'm using chantools to conduct a zombie channel recovery. I am making an offer:

chantools zombierecovery makeoffer --node1_keys preparedkeys-2024-08-25-xxx.json --node2_keys preparedkeys-2024-08-26-xxx.json --feerate 4

I input my keys and am asked "How many sats should go to you (bc1pxxxxx) before fees?:"

I enter 0 and get the following panic:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x47169a]

goroutine 1 [running]:
main.(*zombieRecoveryMakeOfferCommand).Execute(0xc0000bb280, 0x12?, {0xc000291820?, 0x127ce00?, 0xc00001bac0?})
	/home/ubuntu/git/chantools/cmd/chantools/zombierecovery_makeoffer.go:327 +0x1c6f
github.com/spf13/cobra.(*Command).execute(0xc0001c0588, {0xc0002ea900, 0x6, 0x6})
	/home/ubuntu/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:852 +0x69d
github.com/spf13/cobra.(*Command).ExecuteC(0x262f300)
	/home/ubuntu/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:960 +0x389
github.com/spf13/cobra.(*Command).Execute(...)
	/home/ubuntu/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:897
main.main()
	/home/ubuntu/git/chantools/cmd/chantools/root.go:138 +0x55e
@Liongrass
Copy link
Author

I also run into this error when entering any other amount than zero.

@lightninglabs lightninglabs deleted a comment Aug 26, 2024
@guggero
Copy link
Member

guggero commented Aug 26, 2024

What version are you using? I think this might have been fixed in the latest one. If not, it would be helpful to get the stack trace from the latest version.

@Liongrass
Copy link
Author

I compiled chantools from the latest master only yesterday. Commit c6ffe382739c7c223ab393f9aa6453a6eadb3261

guggero added a commit that referenced this issue Aug 27, 2024
@guggero
Copy link
Member

guggero commented Aug 27, 2024

Ah, okay. Thanks. Can you check if #159 fixes this for you?

@Liongrass
Copy link
Author

Yes great, that worked! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@guggero @Liongrass and others