-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies (LND v0.18.0-beta and co) #138
update dependencies (LND v0.18.0-beta and co) #138
Conversation
5fbb198
to
e63a879
Compare
e63a879
to
beaac0d
Compare
Updated PR. Loop just released loop v0.28.3, using it instead of a non-tagged commit. |
beaac0d
to
a9f9808
Compare
Updated PR. Updated LND to v0.18.0-beta.1. |
a9f9808
to
2fd1e8b
Compare
Updated PR. Updated lndclient to v0.18.0-2. |
@guggero: review reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the update!
Have one request, otherwise looks good to me 💯
Updated versions: - lnd: v0.17.4-beta -> v0.18.0-beta - lnd/kvdb: v1.4.4 -> v1.4.8 - lnd/tor: v1.1.2 -> v1.1.3 - lnd/healthcheck: v1.2.3 -> v1.2.4 - lnd/tlv: v1.1.1 -> v1.2.6 - neutrino: v0.16.0 -> v0.16.1-0.20240425105051-602843d34ffd - neutrino/cache: v1.1.1 -> v1.1.2 - lndclient: v0.17.4-1 -> v0.18.0-2 - loop: v0.26.6-beta -> v0.28.3 - loop/swapserverrpc: v1.0.5 -> v1.0.8 - pool: v0.6.2-beta.0.20230329135228-c3bffb52df3a -> v0.6.5-beta.0.20240531084722-4000ec802aaa - pool/auctioneerrpc: v1.0.7 -> v1.1.2 - aperture: v0.1.21-beta.0.20230705004936-87bb996a4030 -> v0.3.2-beta - replace of protobuf: v1.30.0-hex-display -> v1.33.0-hex-display - Go: 1.21 -> 1.22.3 Pool version v0.6.5-beta.0.20240531084722-4000ec802aaa was used because it uses LND v0.18.0-beta, not v0.18.0-beta.rc3. Fixed imports and API changes. Updated Go version in README. Updated LND version in cmd/chantools/root.go. Ran `make docs`.
2fd1e8b
to
6ea680c
Compare
Remove deprecated and deactivated linters from .golangci.yml. Ignore too noisy linters: protogetter, depguard, mnd. Fix linter warnings. Use timeout instead of deadline in .golangci.yml.
Copy a file to temp directory before opening it. Fix lightninglabs#139
6ea680c
to
65d6e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Updated versions:
Pool version v0.6.5-beta.0.20240531084722-4000ec802aaa was used because it uses LND v0.18.0-beta, not v0.18.0-beta.rc3.
Fixed imports and API changes.
Updated Go version in README.
Updated LND version in cmd/chantools/root.go.
Ran
make docs
.Updated golangci-ling, because its old version crashed trying to parse Go 1.22.3 version:
lint: update configs, golangci-lint to v1.59.0
Remove deprecated and deactivated linters from .golangci.yml.
Ignore too noisy linters: protogetter, depguard, mnd.
Fix linter warnings.
Use timeout instead of deadline in .golangci.yml.
test: don't modify test data
Copy a file to temp directory before opening it.
Fix #139