Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: re-enable the linter #699

Merged
merged 2 commits into from
Jan 3, 2024
Merged

linter: re-enable the linter #699

merged 2 commits into from
Jan 3, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Dec 19, 2023

The linter was disabled before due to a bug. Since the bug was likely
caused by an issue with a go module in a dependency project which was
updated in the meantime, we attempt to re-enable the linter in the CI
now.

Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉! This will be really helpful!

@lightninglabs-deploy
Copy link

@ellemouton: review reminder

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaayyyy 🔥 just needs a rebase

The linter was disabled before due to a bug. Since the bug was likely
caused by an issue with a go module in a dependency project which was
updated in the meantime, we attempt to re-enable the linter in the CI
now.
@guggero guggero merged commit c757746 into master Jan 3, 2024
12 checks passed
@guggero guggero deleted the linter-fixes branch January 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants