Prepare for custom channels (lnd v0.18.4-beta) #848
Conversation
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
8ab9d4c to
5c64ab5
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
5c64ab5 to
35e6aea
Compare
|
Similar to lightninglabs/loop#828, I bumped to We will want to wait with merging this until the full dependency chain above is resolved. But once |
|
Need to add #861. |
|
@jamaljsr I tagged you for review on this with the intention of asking you to run a full manual test run of this version within Polar (all the tests you've run previously). |
|
@guggero Thanks for the clarification. I wasn't sure how I should test this or if it was ready. I will try it out in Polar by early next week at the latest, hopefully sooner. Excited to see this functionality getting mainlined 🙌 |
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
35e6aea to
ef8f8cf
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
2 times, most recently
from
23d6696 to
1335e4b
Compare
|
This PR now contains all the recently merged PRs of the |
guggero
force-pushed
the
update-to-lnd-18-4
branch
3 times, most recently
from
3d30a93 to
9476c03
Compare
There was a problem hiding this comment.
tACK LGTM 🔥 🚀
I tested the following scenarios in Polar using this network structure with all litd nodes except for erin which is Core Lightning v24.08.1.
alice --[asset]-> bob --[sats]-> carol --[asset]-> dave
|
[sats]
|
v
erin (core-ln)
- fund asset channel using full asset balance after mint
- fund asset channel using partial asset balance after mint
- fund asset channel using full asset balance after mint + onchain send
- fund asset channel using partial asset balance after mint + onchain send
- fund asset channel using full asset balance from onchain receive
- fund asset channel using partial asset balance from onchain receive
- fund asset channel with
push_sat=5000 - create asset invoice on dave, pay with asset on alice (multi-hop)
- create asset invoice on bob, pay with asset on alice (direct peer)
- create asset invoice on alice, pay with asset on bob (direct peer, opposite direction)
- create asset invoice on alice, pay with asset on dave (multi-hop, opposite direction)
- create asset invoice on dave, pay with sats on bob (sats -> asset)
- create sats invoice on bob, pay with asset on dave (asset -> sats)
- create asset invoice on alice, pay with sats on erin (cln sats -> asset)
- create sats invoice on erin, pay with asset on alice (asset -> cln sats)
- create sats invoice on bob, pay with sats on alice (direct peer, sats -> sats)
- create sats invoice on dave, pay with sats on alice (multi-hop, sats -> sats)
- send asset keysend payment from alice to bob
- send asset keysend payment from alice to carol
Note: I was using commit 35e6aea. I see there have been more pushes since I started testing. Let me know if you'd like another round of testing using the final commits before merging.
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
9476c03 to
cf2458e
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
3 times, most recently
from
8ac370b to
8371d03
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
2 times, most recently
from
dd49654 to
890764a
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
3 times, most recently
from
47f213d to
b674ce2
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
b674ce2 to
411f881
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
95faab7 to
230fc7a
Compare
This commit represents the main integration between lnd running in integrated mode and tapd providing auxiliary components for custom channels.
This change will speed up integration tests by not waiting a full 5 seconds before re-trying the connection to lnd if it fails the first time.
Co-authored-by: Olaoluwa Osuntokun <laolu32@gmail.com> Co-authored-by: Gijs van Dam <gijs@lightning.engineering> Co-authored-by: George Tsagkarelis <george.tsagkarelis@gmail.com>
Add the `priceoraclerpc`, `rfqrpc`, and the `tapchannelrpc` JSON callbacks to the litclient's `Registrations` array. This allows the litclient to use the rpc functions contained in these JSON callbacks.
…gh a build argument
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
230fc7a to
62657a0
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
62657a0 to
f16893d
Compare
This is the mother of all PRs for the custom channel saga. Merging this PR will be the final step for bringing custom channels to a non-experimental version of litd. There are many dependencies (see list/graph below), so it will remain in draft for a bit.
Most of the code in these PRs have already been reviewed on the
0-19-stagingbranch and have just been squashed down into easy-to-review pieces.The following list is an ordered list of dependencies that need to be resolved before this PR can be merged (cc @dstadulis):
lndclient v0.18.4-0that points to release branch with stable commitslndclient v0.18.4-0(and with it also bumping thelndversion), take out of draftlndclient v0.18.4-0(and with it also bumping thelndversion), take out of draftlndclient v0.18.4-0(and with it also bumping thelndversion), take out of draftlnd v0.18.4-betato be tagged (at least an RC tag) [release]: Cherry Pick Commits for LND v0.18.4 Release lightningnetwork/lnd#9173lnd-18-4to track lndv0.18.4-betarelease lndclient#194 point to the tagged version oflndlndclient v0.18.4-6Create and merge Pool PR to reference(not required,lndclient v0.18.4-6litdcompiles without)Create and merge Loop PR to reference(not required,lndclient v0.18.4-6litdcompiles without)lndclient v0.18.4-1loop,pool,tapd)NOTE: This PR includes all recent changes to
litd's0-19-stagingbranch, including the new liquidity tests from #842. There haven't been any other in-flight PRs to the staging branch when writing this.