subserver+status: check map entries before adding new servers #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can quickly access a sub-server by its name.
Let the status manager first check its map of subservers before registering a new one to ensure that an existing subserver is not being overridden.
ellemouton
force-pushed
the
mapSubservers
branch
from
5548299 to
db7d365
Compare
21 tasks
ViktorTigerstrom
approved these changes
Oct 21, 2024
Comment on lines
+3
to
+13
| - [Lightning Terminal](#lightning-terminal) | ||
| - [Bug Fixes](#bug-fixes) | ||
| - [Functional Changes/Additions](#functional-changesadditions) | ||
| - [Technical and Architectural Updates](#technical-and-architectural-updates) | ||
| - [Integrated Binary Updates](#integrated-binary-updates) | ||
| - [LND](#lnd) | ||
| - [Loop](#loop) | ||
| - [Pool](#pool) | ||
| - [Faraday](#faraday) | ||
| - [Taproot Assets](#taproot-assets) | ||
| - [Contributors](#contributors-alphabetical-order) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the subserver manager: use a map instead of an array for subservers. Check that there is no name collision before adding a new server. This is also nice if we want to get a specific subserver by its name (as is done in Prepare for custom channels (lnd v0.18.4-beta) #848).
for the status manager, first check that we are not overriding an existing subserver before we register a new one