Build improvements #890
Merged
Build improvements #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation for bumping the lndclient dependency. Because each lndclient service mock now needs to implement the RawClientWithMacAuth method but with a different type, we can't implement two lndclient service mocks within a single struct, as that would require us to have two methods with the same name but different types. So we split the lnd and rounter mocks into two separate structs.
ellemouton
approved these changes
Oct 30, 2024
Comment on lines
+64
to
+68
| case "DevRPC": | ||
| return &devrpc.Config{ | ||
| ActiveNetParams: &chaincfg.RegressionNetParams, | ||
| GraphDB: &channeldb.ChannelGraph{}, | ||
| }, true |
|
@ViktorTigerstrom: review reminder |
ViktorTigerstrom
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks a lot for this @guggero 🚀!
Leaving 1 question and 1 nit 😃
| @@ -94,7 +94,7 @@ DOCKER_TOOLS = docker run \ | |||
| -v $(shell bash -c "mkdir -p /tmp/go-lint-cache; echo /tmp/go-lint-cache"):/root/.cache/golangci-lint \ | |||
| -v $$(pwd):/build litd-tools | |||
|
|
|||
| ITEST_TAGS := integration itest $(LND_RELEASE_TAGS) | |||
| ITEST_TAGS := dev integration itest lowscrypt $(LND_RELEASE_TAGS) | |||
There was a problem hiding this comment.
Hmm I'm not fully sure why the lowscrypt buildtag is added here? Maybe the commit message could be extended to specify that as well if this is intended :)
There was a problem hiding this comment.
Ah, right. Speeds up wallet creation by using weaker encryption. Added that to the commit message.
The dev flag allows us to enable some of lnd's configuration flags that are only available for testing. To speed up any wallet interaction, we also add the lowscrypt build tag that chooses weak encryption for the wallet that is much faster (a couple of milliseconds vs. multiple seconds per wallet creation).
guggero
force-pushed
the
random-improvements
branch
from
6b2562b
to
f50fb91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pull out some commits from #848 that don't have any dependency on
lnd v0.18.4and can be merged immediately.Didn't add release notes as the improvements are mostly build/development related and don't include any end user features.