xPub support for loop out / autoloop out #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
xpub-service
branch
4 times, most recently
from
cd8c3f5
to
b83fdba
Compare
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
hieblmi
commented
Jul 10, 2023
bhandras
reviewed
Jul 12, 2023
liquidity/parameters.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
| } | ||
|
|
||
| addrType := walletrpc.AddressType_UNKNOWN | ||
| switch req.AccountAddrType { |
There was a problem hiding this comment.
nit: can be simplified to an if or a two-case switch.
cmd/loop/liquidity.go
Outdated
| flagSet = true | ||
| } | ||
|
|
||
| if ctx.IsSet("account") != ctx.IsSet("account_addr_type") { |
There was a problem hiding this comment.
nit: validation could be before the params switch.
There was a problem hiding this comment.
I think I could also make it part of the switch itself.
hieblmi
changed the title
hieblmi
force-pushed
the
xpub-service
branch
2 times, most recently
from
5924c35
to
155ac89
Compare
bhandras
reviewed
Jul 24, 2023
GeorgeTsagk
reviewed
Jul 24, 2023
sputn1ck
approved these changes
Jul 27, 2023
sputn1ck
reviewed
Jul 27, 2023
| @@ -1,20 +1,19 @@ | |||
| # Loop Client Release Notes | |||
| This file tracks release notes for the loop client. | |||
There was a problem hiding this comment.
unneccessary line removals here and below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses https://github.com/lightninglabs/nautilus/issues/1000
This PR enables loop out and autoloop out operations to sweep htlcs to addresses generated from an extended public key.
A precondition for using the loop client in this fashion is onboarding a xpub account in the backing lnd instance, e.g.
lncli wallet accounts import xpub... my_loop_account --address_type p2tr --master_key_fingerprint 0df50.Loop outs can then be instructed to sweep to a new derived address from the specified account, e.g:
loop out --amt 10000000 --account my_loop_account --address_type p2tr.To use this functionality with autoloop out one has to set the backing lnd account and address type via liquidity parameters for autoloop, e.g.
loop --network regtest setparams --autoloop=true --account=my_loop_account --account_addr_type=p2tr ...