Allow loopd autogenerated TLS cert validity override with a new flag #614
Conversation
|
Guys a compilation of loopserver for arm64 platform will be really welcome :) it has been painful to test this thing on M1/2 chipsets. |
There was a problem hiding this comment.
Thanks for the useful PR!
LGTM, pending line length (see: https://github.com/lightningnetwork/lnd/blob/master/docs/code_formatting_rules.md#80-character-line-length for reference)
We will have a loopserver arm image out soon (PR on serverside is pending), thanks for the reminder.
gcaracuel
force-pushed
the
tlsvalidity_flag
branch
2 times, most recently
from
9ac8db6
to
96b2d83
Compare
we now have an arm64 image available! |
gcaracuel
force-pushed
the
tlsvalidity_flag
branch
2 times, most recently
from
2241137
to
b3a61d6
Compare
|
Refactored PR with your suggestion, it looks way better now, thanks! |
… flag Co-authored-by: George Tsagkarelis <34623190+GeorgeTsagk@users.noreply.github.com>
gcaracuel
force-pushed
the
tlsvalidity_flag
branch
from
b3a61d6
to
123d531
Compare
Co-authored-by: George Tsagkarelis <34623190+GeorgeTsagk@users.noreply.github.com>
It was added in the last commits. Copy pasting issues |
Add a new flag
--tlsvaliditythat allows override default ~14months loopd auto generated certificate validity period.Use case example:
When using lndconnect string to reach loopd some user will like to have a valid string for longer of 14 months. For those that has a system to rotate this config it might be useful to change this validity period.