sweepbatcher: add option WithWaitForAddSweep #823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
force-pushed
the
wait-for-AddSweep
branch
from
974d373
to
792d0e6
Compare
WithWaitForAddSweep instructs sweepbatcher to wait for all existing sweeps to be AddSweep'ed in Run before actual starting. This is needed in setups where AddSweep is called after setting up dependencies of FetchSweep, so FetchSweep would fail if called before AddSweep.
starius
force-pushed
the
wait-for-AddSweep
branch
from
792d0e6
to
16b7cf9
Compare
|
Replaced with another approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithWaitForAddSweepinstructs sweepbatcher to wait for all existing sweeps to beAddSweeped in Run before actual starting. This is needed in setups whereAddSweepis called after setting up dependencies ofFetchSweep, soFetchSweepwould fail if called beforeAddSweep.Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes