Generalized notif stream #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
approved these changes
Sep 13, 2024
sputn1ck
force-pushed
the
generalized_notif_stream
branch
3 times, most recently
from
e8ddc78
to
0bc48d0
Compare
sputn1ck
force-pushed
the
generalized_notif_stream
branch
from
0bc48d0
to
506e218
Compare
starius
approved these changes
Sep 19, 2024
notifications/manager.go
Outdated
|
|
||
| cancel() | ||
| // Wait for a bit before reconnecting. | ||
| <-time.After(time.Second * 10) |
There was a problem hiding this comment.
I propose this:
select {
case <-time.After(time.Second * 10):
case <-ctx.Done():
}not to keep this goroutine running for 10 seconds after main context is cancelled.
There was a problem hiding this comment.
Have a new timer version up in a bit, which waits 0 seconds on the first try!
notifications/manager.go
Outdated
| return notifChan | ||
| } | ||
|
|
||
| // Run starts the notification manager. |
There was a problem hiding this comment.
I propose to add to godoc, that it closes readyChan as soon as it makes first successful connection to the stream. Also worth noting, that the function is long-running (not launching a goroutine and returning soon).
sputn1ck
force-pushed
the
generalized_notif_stream
branch
4 times, most recently
from
666edcd
to
882c010
Compare
sputn1ck
force-pushed
the
generalized_notif_stream
branch
from
882c010
to
1ce867f
Compare
|
@sputn1ck, remember to re-request review from reviewers when ready |
sputn1ck
force-pushed
the
generalized_notif_stream
branch
7 times, most recently
from
562ad20
to
6485de0
Compare
sputn1ck
force-pushed
the
generalized_notif_stream
branch
3 times, most recently
from
1f3c9af
to
ea9f5ab
Compare
sputn1ck
force-pushed
the
generalized_notif_stream
branch
from
ea9f5ab
to
579dbfa
Compare
sputn1ck
force-pushed
the
generalized_notif_stream
branch
from
579dbfa
to
41aecc6
Compare
bhandras
approved these changes
Oct 8, 2024
sputn1ck
force-pushed
the
generalized_notif_stream
branch
from
41aecc6
to
42b22ee
Compare
This commit removes the notification stream from the reservation manager and replaces it with a subscriber interface.
This commit adds a generic notification manager that can be used to subscribe to different types of notifications.
This commit adds the notification manager to the loopd daemon.
sputn1ck
force-pushed
the
generalized_notif_stream
branch
from
42b22ee
to
7409ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generalized notif stream that replaces specific streams such as the reservations listener.