multi: generate and pass along HTLC resolution blobs for aux channels #9194
Conversation
Pull reviewers statsStats of the last 30 days for lnd:
|
Roasbeef
force-pushed
the
aux-channel-htlc
branch
from
7ed8998
to
97d8ff9
Compare
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Roasbeef
force-pushed
the
aux-channel-htlc
branch
from
97d8ff9
to
488fe89
Compare
Roasbeef
force-pushed
the
aux-channel-htlc
branch
from
488fe89
to
4be4e8e
Compare
Roasbeef
force-pushed
the
aux-channel-htlc
branch
3 times, most recently
from
18eaebb
to
59c072b
Compare
| # | ||
| v0.4.8#15807814492030881602 | ||
| 0x5555555555555 | ||
| 0x0 |
There was a problem hiding this comment.
So all the fields are empty?
There was a problem hiding this comment.
Hmm, not sure quite how to interpret the output.
The cases get added when somethings fails in the past, so this way even though the tests are randomized we make sure that we never fail an old test case.
|
Not sure what to make of the test failure to |
In this commit, we add some additional attributes to the ResolutionReq struct. These will be used to make sure that we can properly handle all the HTLC variants, on chain. The `AuxSigDesc` will be used to communicate if an HTLC needs to go to the second level or not. It contains the second-level sig information needed to finalize a broadcast to the second level.
Similar to the other blobs we have for the commitment output force close resolution, these blobs will be used to ensure that we have everything needed to sweep aux HTLCs.
…ions In this commit, we populate the resolution blobs for the incoming and outgoing HTLCs. We take care to populate the AuxSigDesc with the correct information, as we need to pass along the second-level aux signature and also sign desc along with it.
In this commit, we add a new method to obtain an option of a preimage to the input.Input struct. This is useful for callers that have an Input, and want to optionally obtain the preimage.
In this commit, we add the set of HtlcBlobs to the taprootBriefcase struct. This new field will store all the resolution blobs for a given HTLC. We also add some new property based tests along the way for adequate test coverage.
When we read/write the aux data, we need to make sure we always set the new fields for aux HTLCs.
With this commit, we update all the resolvers to pass in the new htlc resolution blobs. Along the way, we remove the old blocking guard on this resolution logic for HTLCs with blobs.
In this commit, we expand the `NotifyBroadcast` to include an outpoint index. This is useful as it indicates the index of a given required tx out input.
This is useful for additional context to know which commit the AuxLeafStore is fetching the leaves for.
In this commit, we update the `Budget()` call to factor in the `extraBudget` value. Otherwise, when we go to intialize the fee function, we won't factor in the extra budget, and will determine that we can't broadcast/bump.
Roasbeef
force-pushed
the
aux-channel-htlc
branch
from
59c072b
to
77bd55c
Compare
There was a problem hiding this comment.
Not sure what to make of the test failure to FuzzReplyChannelRange. Nothing in this PR touches anything related to that...
Looks like it's introduced in this PR where we started to use a default value instead of empty. Maybe we do a rebase on master and it will go away...
| HtlcID: fn.Some(htlc.HtlcIndex), | ||
| PayHash: fn.Some(htlc.RHash), | ||
| AuxSigDesc: fn.Some(AuxSigDesc{ | ||
| SignDetails: *txSignDetails, |
There was a problem hiding this comment.
think this is causing the panic in the unit test - the txSignDetails is nil here - maybe we should check it against nil and return an error if there're no signing details?
In this commit, we remove the old blockers on aux channel HTLC resolver logic. In place, we utilize a new set of aux blobs obtained from the
AuxContractResolverto generate blobs that contain everything needed to resolve an aux HTLC. This information is now stored on disk in the cnct within the taproot briefcase. Each time we go to have the sweeper handle an HTLC output, we'll now pass along the blob along side, just like we do for the commitment outputs. Finally, we add a newPreimagemethod to theinput.Inputinterface. As the preimage may only be known after the fact (reveal by peer on/off chain), we need a way to give theAuxSweeera way to obtain the preimage to complete any final witnesses.