-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies to supported libraries only #1549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot!
yeah i agree, lets remove support for the abandoned aws sdk version.
Co-authored-by: David Buchmann <david@liip.ch>
great, this is shaping up well. can you please add a changelog entry explaining what got removed and what to use instead? i fixed the lowest build with php 8.2 in the 3.x branch, rebasing on 3.x should fix it here too. |
I took a stab at fixing the phpunit workflow, but not 100% sure I got right.
I didn't see that, and I'll admit that I'm not sure how to rebase. |
git rebase means that you tell git to update your branch with the 3.x branch and apply your commits at the end of that branch. if you have checked out your fork as |
OK, I'll try that. What I've been doing is going to the github page and
syncing when it says my branch is behind, then pulling to pull local
machine.
But I should learn rebase.
…On Wed, Jan 3, 2024 at 11:36 AM David Buchmann ***@***.***> wrote:
git rebase means that you tell git to update your branch with the 3.x
branch and apply your commits at the end of that branch. if you have
checked out your fork as origin, you could do git remote add liip
***@***.***:liip/LiipImagineBundle.git and git remote update to have
upstream available, then while you are on your branch, you do git rebase
liip/3.x and then git push --force-with-lease. alternatively you can use
git merge to merge the 3.x branch into your branch. that will create a
merge commit, but i can squash the commits while merging so that is fine
too.
—
Reply to this email directly, view it on GitHub
<#1549 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQPW3HNBLNNHYB64B4TYMWJIJAVCNFSM6AAAAABBKJWPF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVG4ZDSNBWGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
constant learning 👍 but i don't want to block your progress, if its too complicated i can do the rebase to keep things moving. |
Yes, please.
Also, can you provide a working version of the flysytem bundle config and
liip_imagine config? I can provide a simple repo if that helps.
I have a messier repo, too, that used to work with Oneup but now won't
install, it's a 2-year-old project and I'm fighting with dependencies. Ugh.
…On Thu, Jan 4, 2024 at 6:47 AM David Buchmann ***@***.***> wrote:
constant learning 👍
but i don't want to block your progress, if its too complicated i can do
the rebase to keep things moving.
—
Reply to this email directly, view it on GitHub
<#1549 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQLR4VF2IIEVIY57E7TYM2QF7AVCNFSM6AAAAABBKJWPF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGA2DENZRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
merged in #1557 i don't have a testing repository around with flysystem |
I took a stab at upgrading the dependencies.
amazonwebservices/aws-sdk-for-php is abandoned, and is the only reason we have to support psr/log ^2. I'm pretty sure we can remove it in this version, as mentioned elsewhere it's only for V1 of the cache. WDYT?