Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies to supported libraries only #1549

Closed
wants to merge 10 commits into from
Closed

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Jan 2, 2024

Q A
Branch? 3.0

I took a stab at upgrading the dependencies.

amazonwebservices/aws-sdk-for-php is abandoned, and is the only reason we have to support psr/log ^2. I'm pretty sure we can remove it in this version, as mentioned elsewhere it's only for V1 of the cache. WDYT?

@dbu dbu changed the base branch from 2.x to 3.x January 2, 2024 19:40
composer.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

yeah i agree, lets remove support for the abandoned aws sdk version.

tacman and others added 3 commits January 2, 2024 13:52
Co-authored-by: David Buchmann <david@liip.ch>
Co-authored-by: David Buchmann <david@liip.ch>
composer.json Show resolved Hide resolved
@dbu
Copy link
Member

dbu commented Jan 3, 2024

great, this is shaping up well.

can you please add a changelog entry explaining what got removed and what to use instead?
please remove the build for symfony 5.4 and the one with php 8.0

i fixed the lowest build with php 8.2 in the 3.x branch, rebasing on 3.x should fix it here too.

@tacman
Copy link
Contributor Author

tacman commented Jan 3, 2024

I took a stab at fixing the phpunit workflow, but not 100% sure I got right.

i fixed the lowest build with php 8.2 in the 3.x branch, rebasing on 3.x should fix it here too.

I didn't see that, and I'll admit that I'm not sure how to rebase.

@dbu
Copy link
Member

dbu commented Jan 3, 2024

git rebase means that you tell git to update your branch with the 3.x branch and apply your commits at the end of that branch. if you have checked out your fork as origin, you could do git remote add liip git@github.com:liip/LiipImagineBundle.git and git remote update to have upstream available, then while you are on your branch, you do git rebase liip/3.x and then git push --force-with-lease. alternatively you can use git merge to merge the 3.x branch into your branch. that will create a merge commit, but i can squash the commits while merging so that is fine too.

@tacman
Copy link
Contributor Author

tacman commented Jan 3, 2024 via email

@dbu
Copy link
Member

dbu commented Jan 4, 2024

constant learning 👍

but i don't want to block your progress, if its too complicated i can do the rebase to keep things moving.

@tacman
Copy link
Contributor Author

tacman commented Jan 4, 2024 via email

@dbu
Copy link
Member

dbu commented Jan 6, 2024

merged in #1557

i don't have a testing repository around with flysystem

@dbu dbu closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants