-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: testLoadFixturesCheckReferences #244
Closed
alexislefebvre
wants to merge
1
commit into
liip:2.x
from
alexislefebvre:fix-testLoadFixturesCheckReferences
Closed
fix: testLoadFixturesCheckReferences #244
alexislefebvre
wants to merge
1
commit into
liip:2.x
from
alexislefebvre:fix-testLoadFixturesCheckReferences
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
fix-testLoadFixturesCheckReferences
branch
from
November 2, 2023 20:12
a0e0f07
to
587c934
Compare
When the bundle uses the
|
This was referenced Nov 12, 2023
alexislefebvre
force-pushed
the
fix-testLoadFixturesCheckReferences
branch
from
November 12, 2023 14:16
a5f0a9b
to
00a5a97
Compare
alexislefebvre
force-pushed
the
fix-testLoadFixturesCheckReferences
branch
from
November 12, 2023 14:17
00a5a97
to
52fc814
Compare
alexislefebvre
commented
Nov 20, 2023
|
||
$referenceRepository = $this->databaseTool->loadFixtures([ | ||
'Liip\Acme\Tests\App\DataFixtures\ORM\LoadUserData', | ||
'Liip\Acme\Tests\App\DataFixtures\ORM\LoadSecondUserData', | ||
])->getReferenceRepository(); | ||
|
||
$this->assertCount(2, $referenceRepository->getReferences()); | ||
$references = (method_exists($referenceRepository, 'getReferencesByClass')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: check that entities are loaded into database before checking the references.
Caches have been removed from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test added in
had been broken in the last months.
This fix works but I can't explain why. 🤷