Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aaa_test_b0 test fails #16

Open
keszybz opened this issue Oct 28, 2021 · 1 comment
Open

aaa_test_b0 test fails #16

keszybz opened this issue Oct 28, 2021 · 1 comment

Comments

@keszybz
Copy link

keszybz commented Oct 28, 2021

I'm trying to build the crate, and one of the tests fail:

---- aaa_test_b0 stdout ----
thread 'aaa_test_b0' panicked at 'assertion failed: `(left == right)`
  left: `Ok(ExpressionI(0))`,
 right: `Err(ParseF64("4.999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999"))`', tests/from_go.rs:65:5

The host system is Fedora 35 with rust-1.55.0-1.fc35.x86_64.

/cc @nabijaczleweli

@nabijaczleweli
Copy link

Norepro on bullseye with cargo 1.54.0 (5ae8d74b3 2021-06-22), but I can reproduce this on cargo 1.56.0 (4ed5d137b 2021-10-04).

The test in question has a comment saying "// Go can parse this, but not Rust:", so it seems that Rust can parse it now, too, since 1.55, and I think this can be attributed to rust-lang/rust@8752b40#diff-670b46e2d44b92b0c2382d9a719b95785cf5797a9775254ea22449f0006608a8. Either way, this is a false negative.

nabijaczleweli added a commit to nabijaczleweli/fasteval that referenced this issue Nov 2, 2021
nabijaczleweli added a commit to nabijaczleweli/fasteval that referenced this issue Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants