Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"debug build detected" is always printed even when --debug is not set #2684

Closed
AkihiroSuda opened this issue Oct 4, 2024 · 1 comment · Fixed by #2694
Closed

"debug build detected" is always printed even when --debug is not set #2684

AkihiroSuda opened this issue Oct 4, 2024 · 1 comment · Fixed by #2694
Labels
bug Something isn't working
Milestone
v1.0

Comments

@AkihiroSuda
Copy link
Member 

$ limactl start
[...]
INFO[0000] [hostagent] debug build detected, adding more guest agent candidates: /usr/_output/share/lima/lima-guestagen
t.Linux-x86_64
[...]

Caused by:
@AkihiroSuda AkihiroSuda added the bug Something isn't working label Oct 4, 2024
@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Oct 4, 2024
norio-nomura added a commit to norio-nomura/lima that referenced this issue Oct 7, 2024
@norio-nomura
pkg/usrlocalsharelima: detect debug builds using `debug.ReadBuildInfo…
2b9bb23 
…()` and `os.Executable()`

fixes: lima-vm#2684
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
@norio-nomura norio-nomura mentioned this issue Oct 7, 2024
Closed
@norio-nomura
Copy link
Contributor

I feel that the implementation using debug.ReadBuildInfo() and os.Executable() that was initially used in that PR was better.

@AkihiroSuda AkihiroSuda mentioned this issue Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0
2 participants
@norio-nomura @AkihiroSuda