Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: riscv64: switch from u-boot to EDK2 #2592

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Sep 5, 2024

u-boot no longer needs to be specified as the "kernel" image, as EDK2 (edk2-riscv-code.fd) is available since QEMU v9.1.

ACPI is disabled, as suggested in https://github.com/tianocore/edk2/blob/edk2-stable202408/OvmfPkg/RiscVVirt/README.md#test

@AkihiroSuda AkihiroSuda marked this pull request as ready for review September 11, 2024 10:01
@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Sep 11, 2024
@AkihiroSuda AkihiroSuda requested a review from a team September 17, 2024 08:24
jandubois
jandubois previously approved these changes Sep 26, 2024
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works fine on macOS aarch64 host.

Needs to be rebased to resolve merge conflicts!

@AkihiroSuda
Copy link
Member Author

https://github.com/lima-vm/lima/actions/runs/11138475165/job/30953501156?pr=2592

time="2024-10-02T05:45:39Z" level=fatal msg="failed to load YAML file \"templates/experimental/riscv64.yaml\": can't parse builtin Lima version \"3f3a6f6\": 3f3a6f6 is not in dotted-tri format"

u-boot no longer needs to be specified as the "kernel" image,
as EDK2 (`edk2-riscv-code.fd`) is available since QEMU v9.1.

ACPI is disabled, as suggested in
https://github.com/tianocore/edk2/blob/edk2-stable202408/OvmfPkg/RiscVVirt/README.md#test

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
To avoid "failed to load YAML file \"templates/experimental/riscv64.yaml\": can't parse builtin Lima version \"3f3a6f6\": 3f3a6f6 is not in dotted-tri format"

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@AkihiroSuda AkihiroSuda merged commit cc85e16 into lima-vm:master Oct 2, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants