Run usernet process in background #2595
Conversation
|
Failed test on fedora seems unrelated: |
Could you explain the motivation? |
Similar to the how we run the hostagent process[1], we want to run the
usernet process in the background. Now a program using killpg to cleanup
child processes will not terminate the usernet process.
Example run with this change:
% ps -o pid,pgid,ppid,command
PID PGID PPID COMMAND
55768 55768 55767 -zsh
56126 56126 55768 limactl start userv2.yaml --tty=0
56128 56128 56126 /Users/nsoffer/src/lima/_output/bin/limactl usernet ...
56131 56131 56126 /Users/nsoffer/src/lima/_output/bin/limactl hostagent ...
% ps -o pid,pgid,ppid,command
PID PGID PPID COMMAND
55768 55768 55767 -zsh
56128 56128 1 /Users/nsoffer/src/lima/_output/bin/limactl usernet ...
56131 56131 1 /Users/nsoffer/src/lima/_output/bin/limactl hostagent ...
[1] lima-vm#2574
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
force-pushed
the
usernet-background
branch
from
9a2f753
to
159d1ec
Compare
Sorry, I forgot to link the relevant PR, added in the current version. The issue with the usernet process (that was fixed in the hostagent process) is that it runs in the same process group of the limactl. Since this is always a background process that must continue to run after limactl exit (otherwise user network breaks), it should at least run in a new process group. Ideally it would run as a proper daemon (like qemu --demonize), but this is a bigger change and running in the background is good enough. Here is the relevant code in a program running limactl: I can amend the commit message if needed. |
|
@AkihiroSuda any reason to wait this change? |
Similar to the how we run the hostagent process[1], we want to run the
usernet process in the background. Now a program using killpg to cleanup
child processes will not terminate the usernet process.
Example run with this change:
[1] #2574