Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downloader: re-download digest-less cached images if last-modified differs #2608

Conversation

norio-nomura
Copy link
Contributor

No description provided.

…differs

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
… cached images fails

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
AkihiroSuda
AkihiroSuda previously approved these changes Sep 11, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Eventually we should have a unit test for downloader

@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Sep 11, 2024
jandubois
jandubois previously approved these changes Sep 11, 2024
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
jandubois
jandubois previously approved these changes Sep 12, 2024
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

pkg/downloader/downloader.go Outdated Show resolved Hide resolved
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit c0fda82 into lima-vm:master Sep 19, 2024
25 of 27 checks passed
@norio-nomura norio-nomura deleted the re-download-digest-less-cached-images-if-last-modified-differs branch September 19, 2024 05:50
@norio-nomura
Copy link
Contributor Author

Thanks! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants