Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use errgroup.WithContext #2615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor to use errgroup.WithContext #2615

wants to merge 1 commit into from

Conversation

alexandear
Copy link
Member

The PR simplifies HandleTCPConnection and HandleUDPConnection by replacing chan error with errgroup.WithContext.

@jandubois
Copy link
Member

This branch has conflicts that must be resolved

Conflicting files

  • pkg/portfwd/client.go

@alexandear
Refactor to use errgroup.WithContext
67cfe8b 
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@alexandear
Copy link
Member Author

Resolved conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @jandubois