Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: try macos-14-large (Intel) #2637

Closed
wants to merge 2 commits into from

Conversation

AkihiroSuda
Copy link
Member

This might provide better (or worse) stability

@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Sep 19, 2024
@AkihiroSuda
Copy link
Member Author

Upgrade test is still killed without logs 😥

This might provide better (or worse) stability

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
# on macOS 13, the default vmType is VZ
runs-on: macos-13
# on macOS >= 13, the default vmType is VZ
runs-on: macos-14-large
Copy link
Contributor

@nirs nirs Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intel because you configured the repo with an intel runner?

OK, found the docs, it is very surprising that macos-14-large is intel and macos-14-xlarge is arm64.
https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners/about-larger-runners#about-macos-larger-runners

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the large runners are not available in free organizations; we can only use them because CNCF pays for it (or gets time donated by Microsoft, I don't know).

@AkihiroSuda
Copy link
Member Author

Can any of @lima-vm/committers analyze why the Upgrade test still fails without logs and is marked as “Skipped”?
🤔

@jandubois
Copy link
Member

Can any of @lima-vm/committers analyze why the Upgrade test still fails without logs and is marked as “Skipped”?

I've been trying, but without success so far.

I've removed the retry action, removed the cache, tried to upgrade from 0.20.2 instead of 0.15.1, but the failure remains the same, the running in the upgrade test is hanging after the second ssh message:

time="2024-09-20T00:17:23Z" level=info msg="[hostagent] Starting QEMU (hint: to watch the boot progress, see \"/Users/runner/.lima/test-upgrade/serial.log\")"
[103](https://github.com/jandubois/lima/actions/runs/10950674588/job/30406341318?pr=1#step:6:104)
time="2024-09-20T00:17:23Z" level=info msg="SSH Local Port: 49209"
[104](https://github.com/jandubois/lima/actions/runs/10950674588/job/30406341318?pr=1#step:6:105)
time="2024-09-20T00:17:23Z" level=info msg="[hostagent] Waiting for the essential requirement 1 of 5: \"ssh\""
[105](https://github.com/jandubois/lima/actions/runs/10950674588/job/30406341318?pr=1#step:6:106)
time="2024-09-20T00:17:33Z" level=info msg="[hostagent] Waiting for the essential requirement 1 of 5: \"ssh\""

I think something is so wrong that the runner actually disconnects, and that somehow drops even the logs there were there until that point.

I'm trying a little bit longer, but the jobs are getting queued up, so progress is slow.

I wonder how this test ever passed before.

@jandubois
Copy link
Member

I'm trying a little bit longer, but the jobs are getting queued up, so progress is slow.

I've tried a gazillion different things, and believe the issue is an incompatibility with the latest qemu version from brew and the GitHub runners. It is somewhat surprising, as that version seems to work fine for me locally, also on an Intel Monterey machine.

I've created #2640 and hope it fixes the upgrade test. It will build qemu 8.2.1 from source; if it works, then I will try tomorrow to download the bottle instead. I've been running into some issues with authorization when trying to fetch the bottle with curl, and I'm out of time for now.

BTW, brew no longer supports Monterey, so all formulas will start building from source once they get updated:

Warning: You are using macOS 12.
We (and Apple) do not provide support for this old version.
It is expected behaviour that some formulae will fail to build in this old version.
It is expected behaviour that Homebrew will be buggy and slow.
Do not create any issues about this on Homebrew's GitHub repositories.
Do not create any issues even if you think this message is unrelated.
Any opened issues will be immediately closed without response.
Do not ask for help from Homebrew or its maintainers on social media.
You may ask for help in Homebrew's discussions but are unlikely to receive a response.
Try to figure out the problem yourself and submit a fix as a pull request.
We will review it but may or may not accept it.

@AkihiroSuda
Copy link
Member Author

Thanks @jandubois

Probably no need to use macos-14-large ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants