-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: try macos-14-large (Intel) #2637
Conversation
|
This might provide better (or worse) stability Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
40b144b
to
09bfb1e
Compare
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
09bfb1e
to
741f4b9
Compare
# on macOS 13, the default vmType is VZ | ||
runs-on: macos-13 | ||
# on macOS >= 13, the default vmType is VZ | ||
runs-on: macos-14-large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intel because you configured the repo with an intel runner?
OK, found the docs, it is very surprising that macos-14-large is intel and macos-14-xlarge is arm64.
https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners/about-larger-runners#about-macos-larger-runners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the large runners are not available in free organizations; we can only use them because CNCF pays for it (or gets time donated by Microsoft, I don't know).
Can any of @lima-vm/committers analyze why the Upgrade test still fails without logs and is marked as “Skipped”? |
I've been trying, but without success so far. I've removed the retry action, removed the cache, tried to upgrade from 0.20.2 instead of 0.15.1, but the failure remains the same, the running in the upgrade test is hanging after the second ssh message:
I think something is so wrong that the runner actually disconnects, and that somehow drops even the logs there were there until that point. I'm trying a little bit longer, but the jobs are getting queued up, so progress is slow. I wonder how this test ever passed before. |
I've tried a gazillion different things, and believe the issue is an incompatibility with the latest qemu version from brew and the GitHub runners. It is somewhat surprising, as that version seems to work fine for me locally, also on an Intel Monterey machine. I've created #2640 and hope it fixes the upgrade test. It will build qemu 8.2.1 from source; if it works, then I will try tomorrow to download the bottle instead. I've been running into some issues with authorization when trying to fetch the bottle with BTW, brew no longer supports Monterey, so all formulas will start building from source once they get updated:
|
Thanks @jandubois Probably no need to use macos-14-large ? |
This might provide better (or worse) stability