Use script to pick the qemu formula for the desired version #2642
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
brew-install-version
branch
from
64a444e
to
5de003a
Compare
This will automatically pick the right bottle for the OS of the runner, and we can easily change the QEMU version number without having to look up commit ids manually. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
force-pushed
the
brew-install-version
branch
from
5de003a
to
94dbd79
Compare
jandubois
added a commit
to lima-vm/socket_vmnet
that referenced
this pull request
Sep 22, 2024
Lima doesn't seem to work properly with the latest QEMU on GitHub runners. See also lima-vm/lima#2640 and lima-vm/lima#2642 Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically pick the right bottle for the OS of the runner, and we can easily change the QEMU version number without having to look up commit ids manually.
Based on discussion at #2640 (review)