-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] UI rewrite, code cleanup #188
Open
BocuD
wants to merge
56
commits into
limyz:master
Choose a base branch
from
BocuD:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…width to full width
Log files, unlike config files, aren't something we need to read old versions from. Therefore, moving over to Unicode doesn't come with any drawbacks for these.
This also moves the currently set language source to a single location, which should allow future runtime language configuration independent of the OS language option. CultureInfo.CurrentUILanguage more accurately represents the currently used language, as it is set by the system language rather than the system locale. Some english players might be using Japanese system locale to help render japanese fonts in older games, but still have their display language set to english. This will make DTXMania also run in english for them.
…nd writing This is an initial step to allow refactoring this class into smaller files, in the future the configuration should be rewritten to use an attribute system, or something similar
This is the first step of moving over the new UI system to draw elements using matrices instead of 2D translations, offsets, etc This will allow more complex grouping and animations later on
Future updates will only need to change this number to make a build. In game version and build numbers are derived from this.
This simplifies code in a lot of places and makes it easier to move code over to a new format. Aside from this, it seems to not have been used by anyone in a long time, and is not maintained at all.
It seems to not be used anywhere anymore, and was seemingly only used in a few places in the plugin system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on slowly refactoring and cleaning up the UI code, currently focussing on the configuration menus. I'm opening the PR to open discussion about the topic, as this is not ready to be merged yet (though it should be identical functionality wise to the current release)
The goal is to later on be able to add and change various features building on top of new / improved UI code, but i want to limit this PR to cleaning up and improving code, without making any feature changes for now.
I realize that getting this merged at some point is a tough ask, but i am still making the PR as I want to put in some time and work on this codebase, and i feel like doing so is a better approach than "another fork".
What has been done so far: